dawidwys commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r768546894



##########
File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -179,6 +179,7 @@ public IncrementalRocksDBSnapshotResources 
syncPrepareResources(long checkpointI
 
         return new RocksDBIncrementalSnapshotOperation(
                 checkpointId,
+                !checkpointOptions.isForcedFullSnapshot(),

Review comment:
       But we do have it there already in `CheckpointOptions`.

##########
File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -179,6 +179,7 @@ public IncrementalRocksDBSnapshotResources 
syncPrepareResources(long checkpointI
 
         return new RocksDBIncrementalSnapshotOperation(
                 checkpointId,
+                !checkpointOptions.isForcedFullSnapshot(),

Review comment:
       But we do have it there already there in `CheckpointOptions`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to