zjureel commented on a change in pull request #18239:
URL: https://github.com/apache/flink/pull/18239#discussion_r776548552
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -275,7 +275,7 @@ private void
handleStartDispatcherServicesException(Exception e) throws Exceptio
@Override
public CompletableFuture<Void> onStop() {
log.info("Stopping dispatcher {}.", getAddress());
-
+ super.onStop();
Review comment:
Thanks @akalash. I like the idea of `ClosableRegistry` to close all
resources in one place. In fact it confuses me a little while there're `stop`,
`onStop`, `internalCallOnStop` and `closeAsync` in `RpcEndpoint`. I think it's
very good and necessary to close all the resources in one place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
