KarmaGYZ commented on a change in pull request #18239:
URL: https://github.com/apache/flink/pull/18239#discussion_r776648165



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -275,7 +275,7 @@ private void 
handleStartDispatcherServicesException(Exception e) throws Exceptio
     @Override
     public CompletableFuture<Void> onStop() {
         log.info("Stopping dispatcher {}.", getAddress());
-
+        super.onStop();

Review comment:
       Sounds good to me. Would you like to file a ticket for the rethink of 
resource cleanup protocol in `RpcEndpoint`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to