KarmaGYZ commented on a change in pull request #18239:
URL: https://github.com/apache/flink/pull/18239#discussion_r776554684
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -275,7 +275,7 @@ private void
handleStartDispatcherServicesException(Exception e) throws Exceptio
@Override
public CompletableFuture<Void> onStop() {
log.info("Stopping dispatcher {}.", getAddress());
-
+ super.onStop();
Review comment:
Actually, I don't have a strong preference here. In the current
implementation, we need to claim in the JavaDoc of `RpcEndpoint#onStop` that
the `super.onStop()` should always be called.
I agree it looks fragile and `AutoCloseableRegistry` sounds like a good
idea. However, one can also complain that people might forget to register the
resources to the `AutoCloseableRegistry`.
Either way, I think it is important to document it in a prominent position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
