akalash commented on a change in pull request #18239:
URL: https://github.com/apache/flink/pull/18239#discussion_r776647095
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -275,7 +275,7 @@ private void
handleStartDispatcherServicesException(Exception e) throws Exceptio
@Override
public CompletableFuture<Void> onStop() {
log.info("Stopping dispatcher {}.", getAddress());
-
+ super.onStop();
Review comment:
I thought about it a little more. Right now, I think that in general, we
need to have one pattern for handling resources but it is not clear what it
should be for now and I agree that `AutoCloseableRegistry` also has a problem.
So maybe it makes sense to leave the changes as is at least for now.
If nobody minds of these changes let's wait for the test result and then
merge it. @KarmaGYZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
