fapaul commented on a change in pull request #18397:
URL: https://github.com/apache/flink/pull/18397#discussion_r789453203
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaValueOnlyDeserializerWrapper.java
##########
@@ -62,8 +75,15 @@ public void open(DeserializationSchema.InitializationContext
context) throws Exc
deserializerClass.getName(),
Deserializer.class,
getClass().getClassLoader());
+
+ if (config.isEmpty()) {
+ return;
+ }
+
if (deserializer instanceof Configurable) {
((Configurable) deserializer).configure(config);
+ } else {
Review comment:
Currently, we have the following scenarios:
1. `De/Serializer implements Configurable` I would **only** call
`Configurable.configure`
2. Does not implement Configurable but a configuration is given call
`De/Serializer.configure`
3. No configuration is given we call `De/Serializer.configure` with an empty
map?
Probably you have to write tests for all of them although I am not fully
sure about the last. I guess calling `configure` with an empty map does not
hurt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
