JingsongLi commented on a change in pull request #31:
URL: https://github.com/apache/flink-table-store/pull/31#discussion_r818260224
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java
##########
@@ -304,10 +301,17 @@ private boolean tryCommitOnce(
String manifestListName = null;
List<ManifestFileMeta> oldMetas = new ArrayList<>();
List<ManifestFileMeta> newMetas = new ArrayList<>();
+ Map<Integer, Long> logOffsets = committable.logOffsets();
try {
if (latestSnapshot != null) {
// read all previous manifest files
oldMetas.addAll(manifestList.read(latestSnapshot.manifestList()));
+ // read the last snapshot to complete the bucket's offsets
when logOffsets does not
+ // contain all buckets
+ logOffsets.putAll(
Review comment:
`latestSnapshot.getLogOffsets().forEach(logOffsets::putIfAbsent)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
