[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #31: [FLINK-26293] Store log offsets in snapshot

[GitBox]

JingsongLi commented on a change in pull request #31:
URL: https://github.com/apache/flink-table-store/pull/31#discussion_r818260657



##########
File path: 
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java
##########
@@ -276,7 +273,7 @@ private void tryOverwrite(
 
     private boolean tryCommitOnce(
             List<ManifestEntry> changes,
-            String identifier,
+            ManifestCommittable committable,

Review comment:
       I prefer pass `identifier` and `logOffsets` here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org