JingsongLi commented on a change in pull request #31:
URL: https://github.com/apache/flink-table-store/pull/31#discussion_r818263016
##########
File path:
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/operation/FileStoreCommitTest.java
##########
@@ -150,9 +150,12 @@ public void testOverwritePartialCommit() throws Exception {
TestFileStore store = createStore(false);
store.commitData(
-
data1.values().stream().flatMap(Collection::stream).collect(Collectors.toList()),
- gen::getPartition,
- kv -> 0);
+ data1.values().stream()
+ .flatMap(Collection::stream)
+ .collect(Collectors.toList()),
+ gen::getPartition,
+ kv -> 0)
+ .forEach(snapshot ->
assertThat(snapshot.getLogOffsets().get(0)).isEqualTo(1));
Review comment:
I didn't quite understand your test. As I understand it, the test logic
should be:
- commit with full log offsets, assert.
- commit with partial log offsets (Complemented by the previous snapshot),
assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
