fredia commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r874932077
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java:
##########
@@ -227,6 +229,14 @@ private static void registerSharedState(
for (KeyedStateHandle stateHandle : stateHandles) {
if (stateHandle != null) {
stateHandle.registerSharedStates(sharedStateRegistry,
checkpointID);
+ // Registering state handle to the given sharedStateRegistry
serves two purposes:
+ // 1. let sharedStateRegistry be responsible for cleaning the
state handle,
Review Comment:
Nice suggestion! I think that ID is also unnecessary, because
SharedStateRegistryKey contains state handle id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
