fredia commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r874963782
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -47,23 +50,33 @@ public class SharedStateRegistryImpl implements
SharedStateRegistry {
/** All registered state objects by an artificial key */
private final Map<SharedStateRegistryKey, SharedStateEntry>
registeredStates;
+ /** All registered checkpoints */
+ private final Set<CompletedCheckpoint> registeredCheckpoints;
Review Comment:
I replace `Set<CompletedCheckpoint>` with `Map<Long, CompletedCheckpoint>`
temporarily.
> Do you think it could/should be refactored so that
CompletedCheckpointStore "transfers the ownership" of subsumed checkpoints to
SharedStateRegistry?
> E.g. by passing them to unregisterUnusedState.
I think it would work well, I would try to pass
`DefaultCompletedCheckpointStore.completedCheckpoints` to unregisterUnusedState
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
