fredia commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r874946254
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -137,12 +150,26 @@ public StreamStateHandle registerReference(
return entry.stateHandle;
}
+ @Override
+ public void registerCompletedCheckpoint(CompletedCheckpoint checkpoint) {
+ synchronized (registeredCheckpoints) {
+ LOG.trace("Register checkpoint {}.", checkpoint.getCheckpointID());
+ registeredCheckpoints.add(checkpoint);
+ }
+ }
+
+ @Override
+ public void setPostCleanAction(Runnable postCleanAction) {
+ this.postCleanAction = postCleanAction;
Review Comment:
Nice suggestion. I pass the `subsumAction` as an argument to
unregisterUnusedState, and subsume action contains `postCleanAction`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
