gyfora commented on code in PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889333575
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java:
##########
@@ -274,6 +278,89 @@ public void
verifyInProgressDeploymentWithCrashLoopBackoff() throws Exception {
validatingResponseProvider.assertValidated();
}
+ @ParameterizedTest
+ @EnumSource(FlinkVersion.class)
+ public void cleanUpDeploymentWithError(FlinkVersion flinkVersion)
+ throws JsonProcessingException {
Review Comment:
I think this test case is bit of an overkill.
To reproduce the logic and validate the fix it could simply be replaced with
the following 2 lines:
```
FlinkDeployment flinkDeployment =
TestUtils.buildApplicationCluster();
testController.cleanup(flinkDeployment, context);
```
We don't really need the error state, json etc because thats not related to
the actual issue at hand I think. Also the rest of the method tests
deployments, upgrades etc that are already tested in other methods in this
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
