gyfora commented on code in PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889505556
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -134,6 +135,11 @@ public Configuration getDeployConfig(ObjectMeta
objectMeta, FlinkDeploymentSpec
public Configuration getObserveConfig(FlinkDeployment deployment) {
var deployedSpec = ReconciliationUtils.getDeployedSpec(deployment);
if (deployedSpec == null) {
+ try {
+ LOG.debug("deployment: {}",
objectMapper.writeValueAsString(deployment));
+ } catch (JsonProcessingException e) {
+ LOG.debug("deployment: {}", deployment);
+ }
Review Comment:
I think this debug log does not add any value here. Could we please remove
it?
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -229,14 +229,12 @@ private JarRunResponseBody runJar(
? RestoreMode.DEFAULT
: null);
LOG.info("Submitting job: {} to session cluster.",
jobID.toHexString());
+ var clientTimeout =
+
configManager.getOperatorConfiguration().getFlinkClientTimeout().toSeconds();
+ LOG.debug("clientTimeout: {}", clientTimeout);
Review Comment:
The client timeout configuration is static and already logged on info level
when the operator starts. We should remove the logging here.
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java:
##########
@@ -274,6 +279,15 @@ public void
verifyInProgressDeploymentWithCrashLoopBackoff() throws Exception {
validatingResponseProvider.assertValidated();
}
+ @ParameterizedTest
+ @EnumSource(FlinkVersion.class)
+ public void cleanUpDeploymentWithError(FlinkVersion flinkVersion)
+ throws JsonProcessingException {
+ FlinkDeployment flinkDeployment = TestUtils.buildApplicationCluster();
+ val deleteControl = testController.cleanup(flinkDeployment, context);
Review Comment:
I think you accidentally used lombok `val` instead of `var`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
