pltbkd commented on code in PR #20612:
URL: https://github.com/apache/flink/pull/20612#discussion_r949743163
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceDynamicFileEnumerator.java:
##########
@@ -159,6 +161,9 @@ RowData createRowData(RowType rowType, Map<String, String>
partitionSpec) {
throw new UnsupportedOperationException(
"Unsupported type for dynamic filtering:" +
rowType.getTypeAt(i));
}
+ if (!fieldType.isNullable() && convertedValue == null) {
Review Comment:
If the filed is nullable, the null value will set to the field and compare
with the DynamicFilteringData normally, which will not cause any exception. The
case has been covered in the original test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
