luoyuxia commented on code in PR #20612:
URL: https://github.com/apache/flink/pull/20612#discussion_r950039187
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceDynamicFileEnumerator.java:
##########
@@ -159,6 +161,9 @@ RowData createRowData(RowType rowType, Map<String, String>
partitionSpec) {
throw new UnsupportedOperationException(
"Unsupported type for dynamic filtering:" +
rowType.getTypeAt(i));
}
+ if (!fieldType.isNullable() && convertedValue == null) {
Review Comment:
What if the filed type is declared as notnullable, but the actual data is in
here is null?
Seems we will miss such partition and then cause lossing data.
Is it possible to handle such case? Or at least we should throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
