pltbkd commented on code in PR #20612:
URL: https://github.com/apache/flink/pull/20612#discussion_r949875483
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceDynamicFileEnumerator.java:
##########
@@ -131,6 +132,7 @@ RowData createRowData(RowType rowType, Map<String, String>
partitionSpec) {
GenericRowData rowData = new GenericRowData(rowType.getFieldCount());
for (int i = 0; i < rowType.getFieldCount(); ++i) {
String value =
partitionSpec.get(dynamicFilterPartitionKeys.get(i));
+ LogicalType fieldType = rowType.getTypeAt(i);
Object convertedValue =
Review Comment:
I'd suggest not to do the short-cut. The inner type conversions support
converting null values, and in case any of the conversions converts a non-null
value to a null value, which may lead to NPE, I think it's better set/skip the
null values after the inner conversions are done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
