gaborgsomogyi commented on code in PR #21247:
URL: https://github.com/apache/flink/pull/21247#discussion_r1018270360


##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -429,13 +428,12 @@ private void createTestTopic(String topic, int 
numPartitions, short replicationF
                 admin.createTopics(
                         Collections.singletonList(
                                 new NewTopic(topic, numPartitions, 
replicationFactor)));
-        result.all().get(1, TimeUnit.MINUTES);

Review Comment:
   Moved.



##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/testutils/KafkaSinkExternalContext.java:
##########
@@ -100,10 +98,7 @@ private void createTopic(String topicName, int 
numPartitions, short replicationF
                 replicationFactor);
         NewTopic newTopic = new NewTopic(topicName, numPartitions, 
replicationFactor);
         try {
-            kafkaAdminClient

Review Comment:
   Moved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to