XComp commented on code in PR #21247:
URL: https://github.com/apache/flink/pull/21247#discussion_r1018776191
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java:
##########
@@ -1238,7 +1238,7 @@ public void runProduceConsumeMultipleTopics(boolean
useLegacySchema) throws Exce
// create topics with content
final List<String> topics = new ArrayList<>();
for (int i = 0; i < numTopics; i++) {
- final String topic = topicNamePrefix + i;
+ final String topic = topicNamePrefix + i + UUID.randomUUID();
Review Comment:
> sorry for being nitpicky about this specific one but I feel like here it's
even more crucial that we add a separator since we provide this i identifier to
each topic which would be kind of swallowed into the UUID.
I see, makes sense. You missed my initial comment, though. I shouldn't have
added the second comment to this thread, I guess. Sorry for that one. But I
think that the separator is important in the case above.
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java:
##########
@@ -1238,7 +1238,7 @@ public void runProduceConsumeMultipleTopics(boolean
useLegacySchema) throws Exce
// create topics with content
final List<String> topics = new ArrayList<>();
for (int i = 0; i < numTopics; i++) {
- final String topic = topicNamePrefix + i;
+ final String topic = topicNamePrefix + i + UUID.randomUUID();
Review Comment:
> sorry for being nitpicky about this specific one but I feel like here it's
even more crucial that we add a separator since we provide this i identifier to
each topic which would be kind of swallowed into the UUID.
I see, makes sense. You missed my initial comment, though. I shouldn't have
added the second comment to this thread, I guess. Sorry for that one. But I
think that the separator is important in the case above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
