gaborgsomogyi commented on code in PR #21247:
URL: https://github.com/apache/flink/pull/21247#discussion_r1018279703
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java:
##########
@@ -1238,7 +1238,7 @@ public void runProduceConsumeMultipleTopics(boolean
useLegacySchema) throws Exce
// create topics with content
final List<String> topics = new ArrayList<>();
for (int i = 0; i < numTopics; i++) {
- final String topic = topicNamePrefix + i;
+ final String topic = topicNamePrefix + i + UUID.randomUUID();
Review Comment:
There were several places where random was not added so now added them
manually.
Having a function which is not generic I'm not favoring. If we have
`createRandomizedTestTopic` then we enforce devs to use randomness but
sometimes one may need fixed names. That's the reason why I say let's have an
end-to-end concept.
W/o too much consideration I would vote later on to have a
`generateRandomTopicName(String prefix)` and `createTopic(String topic, int
numPartitions, int replicationFactor)`. This way one can play lego based on
needs.
There are some leftovers where no random added because these doesn't have
restart so they either pass or fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
