XComp commented on code in PR #21247:
URL: https://github.com/apache/flink/pull/21247#discussion_r1018791713
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java:
##########
@@ -204,7 +204,7 @@ public void testFlushAfterClosed() {
@Test(timeout = 30000L)
public void
testProducerWhenCommitEmptyPartitionsToOutdatedTxnCoordinator() throws
Exception {
- String topic = "flink-kafka-producer-txn-coordinator-changed";
+ String topic = "flink-kafka-producer-txn-coordinator-changed-" +
UUID.randomUUID();
Review Comment:
Just an example code location where I don't understand why we have to add
randomness. As far as I understand now (and based on your previous comment),
we're adding the randomness in cases where a test retry is potentially
triggered due to some flakiness. I would understand if a topic is reused in
other tests which is also not the case here.
It feels that I'm missing something here because I don't see none of the
reasonings I could come up with being applied here, for instance. There are a
few other tests where I'm struggling to find the reason as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
