zhuzhurk commented on code in PR #21672:
URL: https://github.com/apache/flink/pull/21672#discussion_r1089860256


##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/DagOptimizationTest.xml:
##########
@@ -273,7 +273,7 @@ Calc(select=[a AS a1, b, c AS c2])(reuse_id=[3])
    :- Exchange(distribution=[hash[a]])
    :  +- Calc(select=[a, b], where=[(a <= 10)])
    :     +- Reused(reference_id=[1])
-   +- Exchange(distribution=[hash[a2]], shuffle_mode=[BATCH])

Review Comment:
   However, I think we should keep `DagOptimizationTest` and 
`DeadlockBreakupTest` to run with all-exchanges-pipelined, because they are 
testing whether deadlocks are avoided in pipelined shuffle cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to