zhuzhurk commented on code in PR #21672:
URL: https://github.com/apache/flink/pull/21672#discussion_r1089877362
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/DynamicFilteringITCase.java:
##########
@@ -48,9 +48,7 @@ public class DynamicFilteringITCase extends BatchTestBase {
private Catalog catalog;
static Stream<Arguments> parameters() {
- return Stream.of(
- Arguments.of(BatchShuffleMode.ALL_EXCHANGES_BLOCKING),
- Arguments.of(BatchShuffleMode.ALL_EXCHANGES_PIPELINED));
+ return
Stream.of(Arguments.of(BatchShuffleMode.ALL_EXCHANGES_BLOCKING));
Review Comment:
I noticed a problem (FLINK-30815) of SQL tests which makes it hard to do
this change.
Therefore, I think it's fine to test blocking exchanges by default because
this is how Flink batch is used in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
