zhuzhurk commented on code in PR #21672:
URL: https://github.com/apache/flink/pull/21672#discussion_r1089859804
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/DefaultSlotPoolServiceSchedulerFactory.java:
##########
@@ -223,15 +223,15 @@ public static DefaultSlotPoolServiceSchedulerFactory
fromConfiguration(
}
private static JobManagerOptions.SchedulerType getSchedulerType(
- Configuration configuration, JobType jobType, boolean isDynamic) {
- if (configuration.get(JobManagerOptions.SCHEDULER_MODE)
- == SchedulerExecutionMode.REACTIVE) {
+ Configuration configuration, JobType jobType, boolean
isDynamicGraph) {
+ if (configuration.get(JobManagerOptions.SCHEDULER_MODE) ==
SchedulerExecutionMode.REACTIVE
+ ||
System.getProperties().containsKey("flink.tests.enable-adaptive-scheduler")) {
Review Comment:
This is not consistent with `ClusterOptions#isAdaptiveSchedulerEnabled()`,
which checks system properties only if the SCHEDULER_MODE is not set.
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/DagOptimizationTest.xml:
##########
@@ -273,7 +273,7 @@ Calc(select=[a AS a1, b, c AS c2])(reuse_id=[3])
:- Exchange(distribution=[hash[a]])
: +- Calc(select=[a, b], where=[(a <= 10)])
: +- Reused(reference_id=[1])
- +- Exchange(distribution=[hash[a2]], shuffle_mode=[BATCH])
Review Comment:
Discussed offline. This is caused by switching from all-exchanges-pipelined
to all-exchanged-blocking. In all-exchanged-blocking scenario, the exchange is
not required to be blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
