zhuzhurk commented on code in PR #21672:
URL: https://github.com/apache/flink/pull/21672#discussion_r1089864450
##########
flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigTest.java:
##########
@@ -297,7 +294,7 @@ private void testLoadingSchedulerTypeFromConfiguration(
configFromConfiguration.configure(
configuration, Thread.currentThread().getContextClassLoader());
- assertThat(configFromConfiguration.getSchedulerType().get(),
is(schedulerType));
Review Comment:
This hotfix should happen before all the changes. So that we do not change
something over and over.
##########
flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigTest.java:
##########
@@ -297,7 +294,7 @@ private void testLoadingSchedulerTypeFromConfiguration(
configFromConfiguration.configure(
configuration, Thread.currentThread().getContextClassLoader());
- assertThat(configFromConfiguration.getSchedulerType().get(),
is(schedulerType));
Review Comment:
This hotfix should happen before all the changes. So that we do not change
some lines over and over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
