fredia commented on code in PR #22787:
URL: https://github.com/apache/flink/pull/22787#discussion_r1245192912
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java:
##########
@@ -182,14 +186,20 @@ public TimerGauge getHardBackPressuredTimePerSecond() {
return hardBackPressuredTimePerSecond;
}
+ public TimerGauge getIoBackPressuredTimePerSecond() {
+ return ioBackPressuredTimePerSecond;
+ }
+
public long getBackPressuredTimeMsPerSecond() {
return getSoftBackPressuredTimePerSecond().getValue()
- + getHardBackPressuredTimePerSecond().getValue();
+ + getHardBackPressuredTimePerSecond().getValue()
+ + getIoBackPressuredTimePerSecond().getValue();
Review Comment:
Thanks for the detailed explanation and analysis, treating `changelogTime`
as busy time is better to understand. I have moved the `changelogBusyTime`
into the busy time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
