pnowojski commented on code in PR #22787:
URL: https://github.com/apache/flink/pull/22787#discussion_r1246454668
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java:
##########
@@ -182,6 +186,10 @@ public TimerGauge getHardBackPressuredTimePerSecond() {
return hardBackPressuredTimePerSecond;
}
+ public TimerGauge getChangelogBusyTimeMsPerSecond() {
+ return changelogBusyTimeMsPerSecond;
+ }
+
Review Comment:
Thanks for update, but you have to include this value at least in the
`TaskIOMetricGroup#getBusyTimePerSecond` and
`TaskIOMetricGroup#getAccumulatedBusyTime`. + add a test coverage for that.
Otherwise `busy + idle + backpressured` won't add up to `1000` anymore and
`changelogBusyTimeMsPerSecond` won't be included in the WebUI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
