reswqa commented on code in PR #23013:
URL: https://github.com/apache/flink/pull/23013#discussion_r1266730543
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/DiscardingSink.java:
##########
@@ -25,7 +25,9 @@
* A stream sink that ignores all elements.
*
* @param <T> The type of elements received by the sink.
+ * @deprecated Use {@link
org.apache.flink.streaming.api.functions.sink.v2.DiscardingSink} instead.
*/
+@Deprecated
Review Comment:
Not sure if it's a suitable time to mark it `@Deprecated` now.
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/v2/DiscardingSink.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.functions.sink.v2;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.api.common.SupportsConcurrentExecutionAttempts;
+import org.apache.flink.api.connector.sink2.Sink;
+import org.apache.flink.api.connector.sink2.SinkWriter;
+
+import java.io.IOException;
+
+/**
+ * A special sink that ignores all elements.
+ *
+ * @param <IN> The type of elements received by the sink.
+ */
+@PublicEvolving
+public class DiscardingSink<IN> implements Sink<IN>,
SupportsConcurrentExecutionAttempts {
Review Comment:
I'm not called it `DiscardingSinkV2` as this name sounds a little
uncomfortable. If we still keep this to be called `DiscardingSink`, then the
package name needs to be different (`v2` package has been introduced here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
