reswqa commented on code in PR #23013: URL: https://github.com/apache/flink/pull/23013#discussion_r1280043303
########## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java: ########## @@ -315,6 +315,13 @@ private <I, R> R adjustTransformations( Transformation::getDescription, Transformation::setDescription); + // handle coLocationGroupKey. Review Comment: When I migrated the use of legacy discard sink in [StreamGraphCoLocationConstraintTest.java](https://github.com/apache/flink/pull/23013/commits/f39d85dc04bb54aae265fe769eac501243ce7c19#diff-e476bce2e644b45118686e9cbaf71fd25e0ed5949a2e82dc7c62172cb9a60d57) to the new implementation, I found that `SinkV2` did not properly handle coLocationGroup, so I also fixed this issue for migration. If you think this is worth a separate PR, I agree to split it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org