luoyuxia commented on code in PR #23013: URL: https://github.com/apache/flink/pull/23013#discussion_r1277459386
########## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/v2/DiscardingSink.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.functions.sink.v2; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.common.SupportsConcurrentExecutionAttempts; +import org.apache.flink.api.connector.sink2.Sink; +import org.apache.flink.api.connector.sink2.SinkWriter; + +import java.io.IOException; + +/** + * A special sink that ignores all elements. + * + * @param <IN> The type of elements received by the sink. + */ +@PublicEvolving Review Comment: Just wondering is there any dicuss or vote for making it to `PublicEvolving`. ########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/stream/StreamingSink.java: ########## @@ -173,7 +173,7 @@ public static DataStreamSink<?> sink( } DataStreamSink<?> discardingSink = - stream.addSink(new DiscardingSink<>()).name("end").setParallelism(1); + stream.sinkTo(new DiscardingSink<>()).name("end").setParallelism(1); Review Comment: Do you mean `json_execution_plan` or `execNode plan` described in[ FLIP-190 ](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191336489#FLIP190:SupportVersionUpgradesforTableAPI&SQLPrograms-GeneralJSONPlanAssumptions ) As long as we can keep `execNode plan` same, there won't break `compatibility`, And as i can see, the `execNode plan` won't change by this pr, so I don't think it'll break `compatibility` ########## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java: ########## @@ -315,6 +315,13 @@ private <I, R> R adjustTransformations( Transformation::getDescription, Transformation::setDescription); + // handle coLocationGroupKey. Review Comment: Why change it in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
