gyfora commented on code in PR #755:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1461096099
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java:
##########
@@ -126,6 +126,9 @@ private static <SPEC extends AbstractFlinkSpec> void
updateStatusForSpecReconcil
status.setError(null);
reconciliationStatus.setReconciliationTimestamp(clock.instant().toEpochMilli());
+ // Set observedGeneration
+ status.setObservedGeneration(target.getMetadata().getGeneration());
Review Comment:
I still don't think that this is consistent with the current content of the
lastReconciledSpec metadata. It's not about setting it to the same value
(source of truth) it's also about setting it at the exact same time.
Also we should remove internal useges of the
lastReconciledSpec.meta.generation and replace it with this one. We have tests
for the behaviour so that would validate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
