justin-chen commented on code in PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1463969344
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ########## @@ -126,6 +126,9 @@ private static <SPEC extends AbstractFlinkSpec> void updateStatusForSpecReconcil status.setError(null); reconciliationStatus.setReconciliationTimestamp(clock.instant().toEpochMilli()); + // Set observedGeneration + status.setObservedGeneration(target.getMetadata().getGeneration()); Review Comment: @gyfora I see, thanks for the review. I moved the setting of `observedGeneration` to be at the same time/place as `lastReconciledSpec.meta.generation`, and replaced the internal usage of the latter in two locations. Tests pass, however please advise if there is somewhere I may have overlooked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org