hackergin commented on code in PR #24183:
URL: https://github.com/apache/flink/pull/24183#discussion_r1468993636
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionSignatureTemplate.java:
##########
@@ -44,19 +45,24 @@ final class FunctionSignatureTemplate {
final @Nullable String[] argumentNames;
+ final @Nullable Boolean[] argumentOptionals;
Review Comment:
Currently, since optional is not included as part of inputStrategy,
argumentName and argumentOptional are not involved in the calculation of equal
and hashcode. Therefore, if optional participates in the calculation of
hashCode and equals here, it may result in duplicate inputStrategies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
