hackergin commented on code in PR #24183:
URL: https://github.com/apache/flink/pull/24183#discussion_r1468994767
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionSignatureTemplate.java:
##########
@@ -44,19 +45,24 @@ final class FunctionSignatureTemplate {
final @Nullable String[] argumentNames;
+ final @Nullable Boolean[] argumentOptionals;
+
private FunctionSignatureTemplate(
List<FunctionArgumentTemplate> argumentTemplates,
boolean isVarArgs,
- @Nullable String[] argumentNames) {
+ @Nullable String[] argumentNames,
+ @Nullable Boolean[] argumentOptionals) {
Review Comment:
Removed the `nullable` and generating default optional for each parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
