hackergin commented on code in PR #24183:
URL: https://github.com/apache/flink/pull/24183#discussion_r1469333349
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkConvertletTable.java:
##########
@@ -69,6 +72,10 @@ public SqlRexConvertlet get(SqlCall call) {
return this::convertSetSemanticsWindowTableFunction;
}
+ if (isContainsDefaultNode(call)) {
Review Comment:
```java
RexNode rexCall = StandardConvertletTable.INSTANCE.convertCall(cx, call);
```
The current logic is to convert Sqlcall into RexCall first, and then correct
the types of operands in RexCall. So when converting SqlCall to RexCall,
callBinding still needs to convert default type. Unless we judge whether the
operand is a default type before converting SqlNode into RexCall, and then
correct the type, I think it should be done in
`StandardConvertletTable.INSTANCE.convertCall`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
