hackergin commented on code in PR #24183:
URL: https://github.com/apache/flink/pull/24183#discussion_r1468994153
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/BaseMappingExtractor.java:
##########
@@ -143,6 +144,9 @@ protected Map<FunctionSignatureTemplate,
FunctionResultTemplate> extractResultMa
// check if the method can be called
verifyMappingForMethod(correctMethod,
collectedMappingsPerMethod, verification);
+ // check if we declare optional on a primitive type parameter
+ verifyOptionalOnPrimitiveParameter(correctMethod,
collectedMappingsPerMethod);
+
// check if method strategies conflict with function strategies
collectedMappingsPerMethod.forEach(
(signature, result) -> putMapping(collectedMappings,
signature, result));
Review Comment:
I think we can skip this check here if the user is not using namedArgument,
so I think we don't need to check it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
