eskabetxe commented on code in PR #123:
URL:
https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1676434603
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcConnectorOptions.java:
##########
@@ -19,165 +19,13 @@
package org.apache.flink.connector.jdbc.table;
import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.configuration.ConfigOption;
-import org.apache.flink.configuration.ConfigOptions;
-import org.apache.flink.table.connector.source.lookup.LookupOptions;
-import org.apache.flink.table.factories.FactoryUtil;
-import java.time.Duration;
-
-/** Options for the JDBC connector. */
+/**
+ * Options for the JDBC connector.
+ *
+ * @deprecated please use {@link
org.apache.flink.connector.jdbc.core.table.JdbcConnectorOptions}
Review Comment:
done
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java:
##########
@@ -19,139 +19,16 @@
package org.apache.flink.connector.jdbc.dialect;
import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.connector.jdbc.converter.JdbcRowConverter;
-import org.apache.flink.table.api.ValidationException;
-import org.apache.flink.table.types.logical.RowType;
-
-import java.io.Serializable;
-import java.util.Optional;
+import org.apache.flink.connector.jdbc.core.database.JdbcFactory;
/**
* Represents a dialect of SQL implemented by a particular JDBC system.
Dialects should be immutable
* and stateless.
*
- * @see JdbcDialectFactory
+ * @see JdbcFactory
+ * @deprecated use
org.apache.flink.connector.jdbc.core.table.dialect.JdbcDialect
Review Comment:
done
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialectFactory.java:
##########
@@ -18,41 +18,34 @@
package org.apache.flink.connector.jdbc.dialect;
-import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.connector.jdbc.core.database.JdbcFactory;
import org.apache.flink.util.StringUtils;
/**
- * A factory to create a specific {@link JdbcDialect}. This factory is used
with Java's Service
- * Provider Interfaces (SPI) for discovering.
+ * A factory to create a specific {@link
org.apache.flink.connector.jdbc.dialect.JdbcDialect}. This
+ * factory is used with Java's Service Provider Interfaces (SPI) for
discovering.
*
* <p>Classes that implement this interface can be added to the
- *
"META_INF/services/org.apache.flink.connector.jdbc.dialect.JdbcDialectFactory"
file of a JAR file
- * in the current classpath to be found.
+ * "META_INF/services/org.apache.flink.connector.jdbc.JdbcDialectFactory" file
of a JAR file in the
+ * current classpath to be found.
*
- * @see JdbcDialect
+ * @see org.apache.flink.connector.jdbc.dialect.JdbcDialect
+ * @deprecated use JdbcFactory
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
