eskabetxe commented on code in PR #123:
URL:
https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1676434863
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialectTypeMapper.java:
##########
@@ -18,15 +18,12 @@
package org.apache.flink.connector.jdbc.dialect;
-import org.apache.flink.table.catalog.ObjectPath;
-import org.apache.flink.table.types.DataType;
+import
org.apache.flink.connector.jdbc.core.database.catalog.JdbcCatalogTypeMapper;
-import java.sql.ResultSetMetaData;
-import java.sql.SQLException;
-
-/** Separate the jdbc meta-information type to flink table type into the
interface. */
-public interface JdbcDialectTypeMapper {
-
- DataType mapping(ObjectPath tablePath, ResultSetMetaData metadata, int
colIndex)
- throws SQLException;
-}
+/**
+ * Separate the jdbc meta-information type to flink table type into the
interface.
+ *
+ * @deprecated use JdbcCatalogTypeMapper
Review Comment:
done
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/converter/JdbcRowConverter.java:
##########
@@ -19,34 +19,15 @@
package org.apache.flink.connector.jdbc.converter;
import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.connector.jdbc.statement.FieldNamedPreparedStatement;
+import
org.apache.flink.connector.jdbc.core.database.dialect.JdbcDialectConverter;
import org.apache.flink.table.data.RowData;
-import java.io.Serializable;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-
/**
* Converter that is responsible to convert between JDBC object and Flink SQL
internal data
* structure {@link RowData}.
+ *
+ * @deprecated use JdbcDialectConverter
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
