ASF GitHub Bot commented on FLINK-5091:

Github user EronWright commented on a diff in the pull request:

    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
    @@ -1372,6 +1381,12 @@
        /** The environment variable name which contains the location of the 
lib folder */
        public static final String ENV_FLINK_LIB_DIR = "FLINK_LIB_DIR";
    +   /** The environment variable name which contains the location of the 
bin directory */
    +   public static final String ENV_FLINK_BIN_DIR = "FLINK_BIN_DIR";
    +   /** The environment variable name which contains the Flink installation 
root directory */
    +   public static final String ENV_FLINK_HOME_DIR = "FLINK_HOME";
    --- End diff --
    @Makman2  the standalone TM relies on the `FLINK_CONF_DIR` environment 
variable to find its configuration.  Now the Mesos TM does too, for 
consistency, rather than looking to the working directory.   
    When the AM launches the TM as a Mesos task, it installs Flink to a 
subdirectory within the sandbox directory, and sets the `FLINK_HOME` 
environment variable accordingly.   The variable value is a relative path 
(based on the sandbox directory); it is assumed that the TM working directory 
is the sandbox directory.
    Does this address your concern?

> Formalize the AppMaster environment for docker compability
> ----------------------------------------------------------
>                 Key: FLINK-5091
>                 URL: https://issues.apache.org/jira/browse/FLINK-5091
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management, Mesos
>            Reporter: Eron Wright 
>            Assignee: Eron Wright 
>             Fix For: 1.2.0
> For scenarios where the AppMaster is launched from a docker image, it would 
> be ideal to use the installed Flink rather than rely on a special file layout 
> in the sandbox directory.
> This is related to DCOS integration, which (in 1.2) will launch the AppMaster 
> via Marathon (as a top-level DCOS service).  The existing code assumed that 
> only the dispatcher (coming in 1.3) would launch the AppMaster.  

This message was sent by Atlassian JIRA

Reply via email to