[
https://issues.apache.org/jira/browse/FLINK-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715495#comment-15715495
]
ASF GitHub Bot commented on FLINK-5091:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90664795
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/Krb5ConfOverlay.java
---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.clusterframework.overlays;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.runtime.clusterframework.ContainerSpecification;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+import java.io.File;
+import java.io.IOException;
+
+
+/**
+ * Overlays a Kerberos configuration file into a container.
+ *
+ * The following files are copied to the container:
+ * - krb5.conf
+ *
+ * The following Java system properties are set in the container:
+ * - java.security.krb5.conf
+ */
+public class Krb5ConfOverlay extends AbstractContainerOverlay {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(Krb5ConfOverlay.class);
+
+ static final String JAVA_SECURITY_KRB5_CONF = "java.security.krb5.conf";
+
+ static final Path TARGET_PATH = new Path("krb5.conf");
+ final Path krb5Conf;
+
+ public Krb5ConfOverlay(@Nullable File krb5Conf) {
+ this.krb5Conf = krb5Conf != null ? new Path(krb5Conf.toURI()) :
null;
+ }
+
+ public Krb5ConfOverlay(@Nullable Path krb5Conf) {
+ this.krb5Conf = krb5Conf;
+ }
+
+ @Override
+ public void configure(ContainerSpecification container) throws
IOException {
+ if(krb5Conf != null) {
+
container.getArtifacts().add(ContainerSpecification.Artifact.newBuilder()
+ .setSource(krb5Conf)
+ .setDest(TARGET_PATH)
+ .setCachable(true)
+ .build());
+
container.getSystemProperties().setString(JAVA_SECURITY_KRB5_CONF,
TARGET_PATH.getPath());
+ }
+ }
+
+ public static Builder newBuilder() {
+ return new Builder();
+ }
+
+ /**
+ * A builder for the {@link Krb5ConfOverlay}.
+ */
+ public static class Builder {
+
+ File krb5ConfPath;
+
+ /**
+ * Configures the overlay using the current environment.
+ *
+ * Locates the krb5.conf configuration file as per
+ * <a
href="https://docs.oracle.com/javase/8/docs/technotes/guides/security/jgss/tutorials/KerberosReq.html";>Java
documentation</a>.
+ * Note that the JRE doesn't support the KRB5_CONFIG
environment variable (JDK-7045913).
+ */
--- End diff --
indention is off here
> Formalize the AppMaster environment for docker compability
> ----------------------------------------------------------
>
> Key: FLINK-5091
> URL: https://issues.apache.org/jira/browse/FLINK-5091
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management, Mesos
> Reporter: Eron Wright
> Assignee: Eron Wright
> Fix For: 1.2.0
>
>
> For scenarios where the AppMaster is launched from a docker image, it would
> be ideal to use the installed Flink rather than rely on a special file layout
> in the sandbox directory.
> This is related to DCOS integration, which (in 1.2) will launch the AppMaster
> via Marathon (as a top-level DCOS service). The existing code assumed that
> only the dispatcher (coming in 1.3) would launch the AppMaster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
