[ https://issues.apache.org/jira/browse/FLINK-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715494#comment-15715494 ]
ASF GitHub Bot commented on FLINK-5091: --------------------------------------- Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90454287 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/ContainerOverlay.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.clusterframework.overlays; + +import org.apache.flink.runtime.clusterframework.ContainerSpecification; + +import java.io.IOException; + +/** + * A container overlay to produce a container specification. + * + * An overlay applies configuration elements, environment variables, + * system properties, and artifacts to a container specification. + */ +public interface ContainerOverlay { + + /** + * Configure the given container specification. + */ --- End diff -- Indention is off here > Formalize the AppMaster environment for docker compability > ---------------------------------------------------------- > > Key: FLINK-5091 > URL: https://issues.apache.org/jira/browse/FLINK-5091 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management, Mesos > Reporter: Eron Wright > Assignee: Eron Wright > Fix For: 1.2.0 > > > For scenarios where the AppMaster is launched from a docker image, it would > be ideal to use the installed Flink rather than rely on a special file layout > in the sandbox directory. > This is related to DCOS integration, which (in 1.2) will launch the AppMaster > via Marathon (as a top-level DCOS service). The existing code assumed that > only the dispatcher (coming in 1.3) would launch the AppMaster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)