[
https://issues.apache.org/jira/browse/FLINK-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715493#comment-15715493
]
ASF GitHub Bot commented on FLINK-5091:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2915#discussion_r90666953
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java
---
@@ -542,42 +542,10 @@ protected static File asFile(String path) {
return configs;
}
- // This code is taken from: http://stackoverflow.com/a/7201825/568695
- // it changes the environment variables of this JVM. Use only for
testing purposes!
- @SuppressWarnings("unchecked")
public static void setEnv(Map<String, String> newenv) {
--- End diff --
How about removing this method and redirecting the calls? Was there a
dependency management reason you didn't want to do that?
> Formalize the AppMaster environment for docker compability
> ----------------------------------------------------------
>
> Key: FLINK-5091
> URL: https://issues.apache.org/jira/browse/FLINK-5091
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management, Mesos
> Reporter: Eron Wright
> Assignee: Eron Wright
> Fix For: 1.2.0
>
>
> For scenarios where the AppMaster is launched from a docker image, it would
> be ideal to use the installed Flink rather than rely on a special file layout
> in the sandbox directory.
> This is related to DCOS integration, which (in 1.2) will launch the AppMaster
> via Marathon (as a top-level DCOS service). The existing code assumed that
> only the dispatcher (coming in 1.3) would launch the AppMaster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
