ferenc-csaky commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352245005
One other alternative would be to initialize a `PortRange` in the factory and pass that object in the `PrometheusReporter` ctor. `PortRange` stores the original original string config, and is converted into that in case of `toString()` so it will display the ports correctly. This way we do not need to care about converting to a list at all, simply getting the iterator through the `PortRange`, which was my original intent when I wrote that util. :) A con of this approach might be the usage of a fairly specific class instead of a common interface in the `PrometheusReporter` ctor, but since that ctor is not meant to use and should be instantiated by the factory IMO it does not really matter. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
