ferenc-csaky commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2357883274
> I have looked into the `PortRange` class and I think using that would solve the problem this JIRA is trying to tackle. I like the solution, so just to confirm we would have 2 commits: > > * Move `PortRange` class from flink-runtime to flink-core module, so no additional dependencies required for flink-metrics-prometheus. > * Change constructor of `PrometheusReporter` to require a single parameter of `PortRange`. Yep, exactly what you described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
