eon2208 commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352331809
Using the PortRange as a domain wrapper for the ports seems like a good choice. The question is whether adding the extra dependency to the `flink-metrics-prometheus` module for the single class is worth it (IMO it makes the code more intuitive to read). If so, then I would go for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
