ferenc-csaky commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352393745
> Using the PortRange as a domain wrapper for the ports seems like a good choice. The question is whether adding the extra dependency to the `flink-metrics-prometheus` module for the single class is worth it (IMO it makes the code more intuitive to read). If so, then I would go for it. You make a good paint here, did not check the code in the morning, I thought `PortRange` lives in the same module as `NetUtils`, but it seems I put it into `flink-runtime` as I added the improvement in that module back in the day. `PortRange` is general utility class that makes the `NetUtils#getPortRangeFromString` a bit more user-friendly so I think it makes sense to move them into the same module. @gaborgsomogyi if you have some time, I would appreciate your opinion on this. If agreed, I'll open another ticket about the utility move. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
