becketqin commented on code in PR #25371:
URL: https://github.com/apache/flink/pull/25371#discussion_r1775726090
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -71,7 +71,7 @@ public void testCloseFetcherWithException() throws Exception {
.hasRootCauseMessage("Artificial exception on closing the
split reader.");
}
- @Test(timeout = 30000)
+ @Test
Review Comment:
> I did a test and confirmed even if there are tasks not terminated, the
test still can pass, with or without the timeout = Long.MAX_VALUE.
Hmm, this is not expected. The timeout is used in the
`SplitFetcherManager.close()`
```
executors.awaitTermination(timeoutMs, TimeUnit.MILLISECONDS)
```
This is a blocking call and won't return until the executors finishes all
the tasks, or otherwise be interrupted.
So if the timeout is `Long.MAX_VALUE`, and there are running tasks,
`SplitFetcherManager.close()` will block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
