showuon commented on code in PR #25371:
URL: https://github.com/apache/flink/pull/25371#discussion_r1774665859
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -71,7 +71,7 @@ public void testCloseFetcherWithException() throws Exception {
.hasRootCauseMessage("Artificial exception on closing the
split reader.");
}
- @Test(timeout = 30000)
+ @Test
Review Comment:
Sorry @becketqin , I don't why adding timeout to `Long.MAX_VALUE` will work
when there are tasks not terminated. I did a test and confirmed even if there
are tasks not terminated, the test still can pass, with or without the `timeout
= Long.MAX_VALUE`.
To catch the error when there are tasks failing to be closed, I change the
`close` method to return `boolean`, so that we have a way to know if tasks are
completely closed in time, otherwise, fail the test. Please take a look again.
Thanks.
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -71,7 +71,7 @@ public void testCloseFetcherWithException() throws Exception {
.hasRootCauseMessage("Artificial exception on closing the
split reader.");
}
- @Test(timeout = 30000)
+ @Test
Review Comment:
Sorry @becketqin , I don't get why adding timeout to `Long.MAX_VALUE` will
work when there are tasks not terminated. I did a test and confirmed even if
there are tasks not terminated, the test still can pass, with or without the
`timeout = Long.MAX_VALUE`.
To catch the error when there are tasks failing to be closed, I change the
`close` method to return `boolean`, so that we have a way to know if tasks are
completely closed in time, otherwise, fail the test. Please take a look again.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
