showuon commented on code in PR #25371:
URL: https://github.com/apache/flink/pull/25371#discussion_r1776302945
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -71,7 +71,7 @@ public void testCloseFetcherWithException() throws Exception {
.hasRootCauseMessage("Artificial exception on closing the
split reader.");
}
- @Test(timeout = 30000)
+ @Test
Review Comment:
Sorry @becketqin , I misunderstood your comment. I thought you were asking
me to change this:
```
@Test(timeout = Long.MAX_VALUE)
```
My bad! Just read it again, I understand what you said now. We should set
the max timeout on the `close` method, otherwise, it will only log a warning
and the test passes. So everything makes sense now. Just updated the PR. Please
take a look again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
