davidradl commented on code in PR #25777:
URL: https://github.com/apache/flink/pull/25777#discussion_r1878163358
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecTemporalJoin.java:
##########
@@ -276,12 +278,21 @@ private TwoInputStreamOperator<RowData, RowData, RowData>
createJoinOperator(
isLeftOuterJoin);
} else {
if (isTemporalFunctionJoin) {
- return new TemporalProcessTimeJoinOperator(
- InternalTypeInfo.of(rightInputType),
- generatedJoinCondition,
- minRetentionTime,
- maxRetentionTime,
- isLeftOuterJoin);
+ if
(config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
+ return new AsyncStateTemporalProcessTimeJoinOperator(
Review Comment:
The Jira mentions SQL and table and the component in the PR title mentions
[TABLE], but the fix and test appear to be datastream only. Is there an intent
that this effects table API and SQL?
Please could you update the documentation -as this is new changes to the
API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
